-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename formatter to propagator #851
Merged
mayurkale22
merged 7 commits into
open-telemetry:master
from
dynatrace-oss-contrib:propagator-rename
Mar 13, 2020
Merged
Rename formatter to propagator #851
mayurkale22
merged 7 commits into
open-telemetry:master
from
dynatrace-oss-contrib:propagator-rename
Mar 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
bg451,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
March 12, 2020 14:09
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
==========================================
+ Coverage 92.63% 92.92% +0.28%
==========================================
Files 252 252
Lines 11113 11169 +56
Branches 1069 1080 +11
==========================================
+ Hits 10295 10379 +84
+ Misses 818 790 -28
|
dyladan
changed the title
chore: rename formatter to propagator
Rename formatter to propagator
Mar 12, 2020
mayurkale22
reviewed
Mar 12, 2020
mayurkale22
reviewed
Mar 12, 2020
mayurkale22
reviewed
Mar 12, 2020
mayurkale22
approved these changes
Mar 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, otherwise LGTM
@open-telemetry/javascript-approvers we need more reviews on this! |
OlivierAlbertini
approved these changes
Mar 13, 2020
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* chore: rename formatter to propagator * chore: lint * chore: last few formatter renames * chore: remove test of removed function * chore: remove unused imports
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* chore: rename formatter to propagator * chore: lint * chore: last few formatter renames * chore: remove test of removed function * chore: remove unused imports
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Amir Blum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?