Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename formatter to propagator #851

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 12, 2020

Which problem is this PR solving?

@codecov-io
Copy link

codecov-io commented Mar 12, 2020

Codecov Report

Merging #851 into master will increase coverage by 0.28%.
The diff coverage is 70.96%.

@@            Coverage Diff             @@
##           master     #851      +/-   ##
==========================================
+ Coverage   92.63%   92.92%   +0.28%     
==========================================
  Files         252      252              
  Lines       11113    11169      +56     
  Branches     1069     1080      +11     
==========================================
+ Hits        10295    10379      +84     
+ Misses        818      790      -28     
Impacted Files Coverage Δ
packages/opentelemetry-api/test/api/api.test.ts 96.66% <ø> (ø)
...entelemetry-core/test/context/B3Propagator.test.ts 47.00% <0.00%> (ø)
.../opentelemetry-core/test/context/composite.test.ts 96.42% <ø> (ø)
...ckages/opentelemetry-web/test/registration.test.ts 0.00% <0.00%> (ø)
packages/opentelemetry-api/src/api/propagation.ts 57.14% <66.66%> (ø)
.../src/context/propagation/NoopHttpTextPropagator.ts 100.00% <100.00%> (ø)
packages/opentelemetry-api/src/trace/NoopTracer.ts 100.00% <100.00%> (ø)
...-api/test/noop-implementations/noop-tracer.test.ts 100.00% <100.00%> (+52.17%) ⬆️
...metry-core/src/context/propagation/B3Propagator.ts 96.07% <100.00%> (ø)
...y-core/src/context/propagation/HttpTraceContext.ts 100.00% <100.00%> (ø)
... and 37 more

@dyladan dyladan changed the title chore: rename formatter to propagator Rename formatter to propagator Mar 12, 2020
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, otherwise LGTM

@mayurkale22
Copy link
Member

@open-telemetry/javascript-approvers we need more reviews on this!

@mayurkale22 mayurkale22 merged commit 11be782 into open-telemetry:master Mar 13, 2020
@Flarna Flarna deleted the propagator-rename branch June 12, 2020 21:19
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
* chore: rename formatter to propagator

* chore: lint

* chore: last few formatter renames

* chore: remove test of removed function

* chore: remove unused imports
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* chore: rename formatter to propagator

* chore: lint

* chore: last few formatter renames

* chore: remove test of removed function

* chore: remove unused imports
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename formatter to propagator
4 participants